Review Run #82d47c43

<!-- firmcodeai:activity:summary:v1 --> ```text |----------------------| | FIRMCODEAI | |----------------------| ``` ## FirmcodeAI Summary FirmcodeAI reviewed this PR and found 0 actionable issue(s). ### Code Review No actionable issues were found in the selected changed files. <details> <summary>Risk</summary> - Level: low </details> <details> <summary>Changed Components</summary> - `apps/api` (8 files) - `apps/web` (4 files) - `packages/shared` (1 file) **Changed code** **`apps/api/src/infrastructure/database/migrations.ts`** (+3/-1) ```diff @@ -4,6 +4,7 @@ import { dashboardAuthRetryStateMigration } from "./migrations/003_dashboard_aut import { repositoryReviewConfigurationMigration } from "./migrations/004_repository_review_configuration"; import { githubOAuthAndSyncMigration } from "./migrations/005_github_oauth_and_sync"; import { reviewPoliciesMigration } from "./migrations/006_review_policies"; ! import { ciFailureArtifactsMigration } from "./migrations/007_ci_failure_artifacts"; export interface DatabaseQueryResult<Row = unknown> { readonly rows: Row[]; @@ -25,7 +26,8 @@ export const DATABASE_MIGRATIONS: readonly DatabaseMigration[] = [ dashboardAuthRetryStateMigration, repositoryReviewConfigurationMigration, githubOAuthAndSyncMigration, - reviewPoliciesMigration ! reviewPoliciesMigration, ! ciFailureArtifactsMigration ]; interface AppliedMigrationRow { ``` **`apps/api/src/infrastructure/database/migrations/007_ci_failure_artifacts.ts`** (+15/-0) ```diff @@ -0,0 +1,15 @@ ! import type { DatabaseMigration } from "../migrations"; ! ! export const ciFailureArtifactsMigration: DatabaseMigration = { ! id: "007_ci_failure_artifacts", ! name: "ci failure explanation artifact type", ! sql: ` ! ALTER TABLE analysis_artifacts ! DROP CONSTRAINT analysis_artifacts_type_check; ! ! ALTER TABLE analysis_artifacts ! ADD CONSTRAINT analysis_artifacts_type_check CHECK ( ! artifact_type IN ('diff', 'treesitter', 'semgrep', 'context_pack', 'llm_raw', 'ci_log', 'ci_failure_explanation') ! ); ! ` ! }; ``` **`apps/api/src/modules/app.module.ts`** (+2/-0) ```diff @@ -1,5 +1,6 @@ import { Module } from "@nestjs/common"; import { BillingModule } from "./billing/billing.module"; ! import { CiFailuresModule } from "./ci-failures/ci-failures.module"; import { GitHubDashboardModule } from "./github/github.module"; import { HealthModule } from "./health/health.module"; import { PullRequestsModule } from "./pull-requests/pull-requests.module"; @@ -14,6 +15,7 @@ import { GitHubWebhookModule } from "./webhooks/github/github-webhook.module"; HealthModule, GitHubWebhookModule, GitHubDashboardModule, ! CiFailuresModule, PullRequestsModule, RepositoriesModule, ReviewRunsModule, ``` **`apps/api/src/modules/ci-failures/ci-failures.controller.ts`** (+182/-0) ```diff @@ -0,0 +1,182 @@ ! import { ! BadRequestException, ! Controller, ! Get, ! Headers, ! Inject, ! NotFoundException, ! Param, ! Query, ! UnauthorizedException ! } from "@nestjs/common"; ! import { REVIEW_RUN_STATUSES, type CiFailureDetailResponse, type CiFailureListFilters, type CiFailureListResponse } from "@firmcode/shared"; ! import { ! DASHBOARD_AUTH_STORE, ! roleHasDashboardCapability, ! type DashboardAuthStore, ! type DashboardMembership ! } from "../review-runs/dashboard-auth.store"; ! import { CI_FAILURES_STORE, type CiFailuresStore } from "./ci-failures.store"; ! ... ``` **`apps/api/src/modules/ci-failures/ci-failures.module.ts`** (+51/-0) ```diff @@ -0,0 +1,51 @@ ! import { Module } from "@nestjs/common"; ! import { Pool } from "pg"; ! import type { ApiRuntimeConfig } from "@firmcode/shared"; ! import { API_RUNTIME_CONFIG, apiRuntimeConfigProvider } from "../../config/api-config.provider"; ! import { ! DASHBOARD_AUTH_STORE, ! EmptyDashboardAuthStore, ! PostgresDashboardAuthStore ! } from "../review-runs/dashboard-auth.store"; ! import { CiFailuresController } from "./ci-failures.controller"; ! import { CI_FAILURES_STORE, EmptyCiFailuresStore, PostgresCiFailuresStore } from "./ci-failures.store"; ! ! @Module({ ! controllers: [CiFailuresController], ! providers: [ ! apiRuntimeConfigProvider, ! { ! provide: CI_FAILURES_STORE, ! useFactory: (config: ApiRuntimeConfig) => { ! if (config.nodeEnv === "test") { ... ``` **`apps/api/src/modules/ci-failures/ci-failures.store.ts`** (+475/-0) ```diff @@ -0,0 +1,475 @@ ! import type { ! CiFailureDetailResponse, ! CiFailureFailedJob, ! CiFailureListFilters, ! CiFailureListItem, ! CiFailureListResponse, ! CiFailureRelatedReviewRun, ! CiFailureSuggestedFix, ! ReviewRunArtifact, ! ReviewRunArtifactType, ! ReviewRunLogExcerpt, ! ReviewRunStatus ! } from "@firmcode/shared"; ! import type { DatabaseExecutor } from "../../infrastructure/database/migrations"; ! ! export const CI_FAILURES_STORE = Symbol("CI_FAILURES_STORE"); ! ! export interface CiFailuresStore { ! listCiFailures(input: CiFailureListInput): Promise<CiFailureListResponse>; ! getCiFailureDetail(input: CiFailureDetailLookup): Promise<CiFailureDetailResponse | null>; ... ``` - ...and 7 more changed files. </details> <details> <summary>Suggested Tests</summary> - Run the affected TypeScript/JavaScript unit tests and type checks. </details> _{FirmcodeAI grounds this summary in changed files and automated review evidence.}